Conversation
The channel check introduced in commit: cdb7f91 ("audio: module_adapter: bound host channels_count at ipc4 init") does not let probes module through. Add extra condition to allows probes that relies on ipc4 probes implementation on Linux ASoC side, that initializes the whole base config as zero for probes module. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The exception can misclassify malformed non-probe configurations and bypass channel validation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Allows IPC4 probe initialization with a zeroed base configuration while retaining channel-count validation.
Changes:
- Detects zeroed base configurations.
- Exempts them from channel-count validation.
| File | Description |
|---|---|
src/audio/module_adapter/module_adapter_ipc4.c |
Adds the probe configuration exception. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+129
to
+130
| /* Check if entire base config is all zero, as it is with probe module */ | ||
| static bool is_probe_module(struct ipc4_base_module_cfg *base_cfg) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The channel check introduced in commit:
cdb7f91 ("audio: module_adapter: bound host channels_count at ipc4 init")
does not let probes module through. Add extra condition to allows probes that relies on ipc4 probes implementation on Linux ASoC side, that initializes the whole base config as zero for probes module.
Fixes: #11254